Skip to content

Fix Account Factories table stuck in loading state #5058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix Account Factories table stuck in loading state #5058

merged 1 commit into from
Oct 16, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 16, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on updating the enabled condition in the AccountFactories component to check if contractListQuery.data is truthy instead of checking its length.

Detailed summary

  • Changed the enabled property from checking !!contractListQuery.data?.length to !!contractListQuery.data.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7738020

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 9:51pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 16, 2024 9:51pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 16, 2024 9:51pm
wallet-ui ⬜️ Skipped (Inspect) Oct 16, 2024 9:51pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 16, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank marked this pull request as ready for review October 16, 2024 21:38
@codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (85e7d15) to head (7738020).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5058   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54724    54724           
  Branches     3953     3953           
=======================================
  Hits        24786    24786           
  Misses      29247    29247           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 85e7d15
packages 40.23% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 518 ms (+57.38% 🔺) 1.4 s
thirdweb (cjs) 102.62 KB (0%) 2.1 s (0%) 677 ms (-12.53% 🔽) 2.8 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 72 ms (+227.04% 🔺) 168 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 83 ms (+772.53% 🔺) 93 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 108 ms (+19% 🔺) 455 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 16, 2024 •
edited by MananTank
Loading

Merge activity

@MananTank
Fix Account Factories table stuck in loading state (#5058)
7738020 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `enabled` property in the `AccountFactories` component's logic to check for the presence of data in `contractListQuery` more accurately.

### Detailed summary
- Changed the condition for the `enabled` property from checking `!!contractListQuery.data?.length` to `!!contractListQuery.data`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-17-fix_account_factories_table_stuck_in_loading_state branch from c7210a1 to 7738020 Compare October 16, 2024 21:48
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 16, 2024 21:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 16, 2024 21:48 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 16, 2024 21:48 Inactive
@graphite-app graphite-app bot merged commit 7738020 into main Oct 16, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 10-17-fix_account_factories_table_stuck_in_loading_state branch October 16, 2024 21:52
@vercel vercel bot temporarily deployed to Production – docs-v2 October 16, 2024 21:52 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 16, 2024 21:52 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 16, 2024 21:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls